Added a 'wait' argument to control how long the radio waits to receive a message #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoamyGuy
requested changes
Sep 26, 2021
|
Thanks again @FoamyGuy for your feedback! I made the changes on my branch, but I'm not sure if I need to close this request and open a new one, or is it possible to share my newest commits within this request? |
|
@mlupo thanks for working on that. They are updated here automatically once pushed into your branch so there is no need to close / make a new PR. This one contains all of the latest changes now. I will circle back and look this over again this evening. |
|
Woo! Thanks again for your help @FoamyGuy! |
|
@mlupo you are welcome! Thanks again for the enhancement. Congrats if this was your first contribution to a CircuitPython Library🎉 |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Sep 28, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Radio to 0.4.0 from 0.3.5: > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Radio#16 from mlupo/main > Globally disabled consider-using-f-string pylint check > Moved default branch to main > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template Updating https://github.com/adafruit/Adafruit_CircuitPython_IterTools to 1.1.6 from 1.1.5: > Merge pull request adafruit/Adafruit_CircuitPython_IterTools#14 from earthprelude/add-init-file > Globally disabled consider-using-f-string pylint check > Moved default branch to main > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template > "Increase duplicate code check threshold "
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a project using a few Circuit Playground Bluefruit boards, I needed a way to control how long each board waited for a new message. With the edits in this request, it is possible to pass a
waitkeyword argument to anyreceivecall.Usage, in my case:
radio.receive(wait=0.2)I am not a programmer by trade, so my apologies if this is absolutely not the right way to do a pull request!