Skip to content

Pylint and RTD update patch, and other fixes #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2021
Merged

Pylint and RTD update patch, and other fixes #18

merged 2 commits into from
Nov 12, 2021

Conversation

evaherrada
Copy link
Collaborator

No description provided.

@github-actions
Copy link

👋 Thanks for this pull request! Unfortunately, it looks like the automated continuous integration (CI) test(s) failed. These can be tricky to fix so we've written a guide on how to fix them locally. It has pages about running pre-commit locally and another about building the docs locally with sphinx. Thanks for contributing to CircuitPython! If you have more questions, feel free to join the Adafruit Discord and post in #circuitpython-dev.

@kattni
Copy link

kattni commented Nov 12, 2021

@dherrada Please resolve the CI failures. Thanks!

@evaherrada
Copy link
Collaborator Author

evaherrada commented Nov 12, 2021

@kattni Let me know if this is good or if you want me to rename the functions. I'm not entirely sure how the tests directory works, so I don't really want to break anything, but if it'd be better to rename them I have no issues with that

@kattni
Copy link

kattni commented Nov 12, 2021

@dherrada This is fine. If further fixes are needed, we'll deal with it then. Merge when passing.

@kattni kattni merged commit 57f2865 into main Nov 12, 2021
@evaherrada evaherrada deleted the patch branch November 12, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants