Type annotations. Issue #45 #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also added import for the i2c type inside of a try except
…d SPI in try except
Closed
16 tasks
tekktrik
requested changes
Apr 19, 2022
|
Thanks for the super kind, speedy, and helpful review @tekktrik! I appreciate you looking it over and educating me |
tekktrik
approved these changes
Apr 20, 2022
|
My pleasure! Thanks for taking the time to do this! Looks good to me! |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Apr 20, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_BME680 to 3.4.3 from 3.4.2: > Merge pull request adafruit/Adafruit_CircuitPython_BME680#49 from billvanleeuwen424/main > Update Black to latest. > Fixed readthedocs build > Consolidate Documentation sections of README Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Shapes to 2.4.3 from 2.4.2: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Shapes#47 from tekktrik/dev/divide-by-zero > Update Black to latest. > Merge branch 'ladyada:master' into main > Fixed readthedocs build > Post-patch cleanup Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.12.0 from 1.11.5: > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#65 from tekktrik/dev/multiple-wifi Updating https://github.com/adafruit/Adafruit_CircuitPython_RSA to 1.2.8 from 1.2.7: > Merge pull request adafruit/Adafruit_CircuitPython_RSA#27 from tekktrik/doc/add-documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing the type annotations issue. Mostly the same as the last PR I created for the BMP280.
issue link:
#45