Skip to content

Fix temperature readings and speed things up. #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 16, 2018

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Mar 15, 2018

  • The default internal attribute values for oversampling were
    incorrect because they needed to be the register values, not the
    human friendly ones.
  • Reduce the delay after reset.
  • Reduce the read delay by polling the new data bit.
  • Introduce refresh_rate setting which allows for returning cached
    values when the properties are accessed quickly.
  • I2C writes do not auto-increment so reset the register address
    for every value.

Fixes #5

* The default internal attribute values for oversampling were
  incorrect because they needed to be the register values, not the
  human friendly ones.
* Reduce the delay after reset.
* Reduce the read delay by polling the new data bit.
* Introduce refresh_rate setting which allows for returning cached
  values when the properties are accessed quickly.
* I2C writes do not auto-increment so reset the register address
  for every value.

Fixes adafruit#5
@tannewt tannewt requested a review from sommersoft March 15, 2018 18:53
Copy link
Collaborator

@sommersoft sommersoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@sommersoft sommersoft merged commit d2689d0 into adafruit:master Mar 16, 2018
tannewt pushed a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Apr 2, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_BME680 to 3.0.2 from 3.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_BME680#7 from chickadee-tech/fix_bme680
  > Merge pull request adafruit/Adafruit_CircuitPython_BME680#6 from sommersoft/new_docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants