-
Notifications
You must be signed in to change notification settings - Fork 53
Made members that store sensor data properties. Removed deprecated members. disabled members return none #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
855c4d8
Pushing for review, not sure why it's not working
evaherrada 84ff6fd
Updated simpletest to not use deprecated variable names anymore
evaherrada e28bc77
Made members that store sensor dataproperties. Removed deprecated mem…
evaherrada c0bd6b8
Fixing pylint issues
evaherrada 938c4e8
Revert "Fixing pylint issues"
evaherrada f769261
Fixed pylint
evaherrada ef30024
Removed setters since they weren't needed after all
evaherrada b416aa8
Merge branch 'master' of https://github.com/dherrada/Adafruit_Circuit…
evaherrada f324666
changed modes in list from dec to hex consts, updated docstrings to r…
evaherrada 1795dfa
Updated mode docstring
evaherrada e5798a3
Fixed trailing whitespace
evaherrada File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also update the docstrings of the mode property and the new properties that may return
None
to describe the new behavior.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't change anything in the mode property, so I'm not really sure what I'd change on that docstring, but I'll do the docstrings for the new properties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docstrings in the individual properties are great. All I would do for the mode property is to add a legend at the top of the table to describe what each symbol in the table means (x=on, -=off and will return an empty tuple)