Fix fusion modes #76
Merged
Fix fusion modes #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My first time making a proposed change. When I look into the checks, the only details I see are "Consider using a generator instead 'tuple" for lines I haven't changed. If I need to change something, let me know what's needed. Thanks! |
|
@ViennaMike Yeah, so that's a check that recently got added to pylint. I'll fix that for you since it's something that I should have done anyway and then just run black. If you do want to learn more about pylint and black go here: https://learn.adafruit.com/improve-your-code-with-pylint |
|
Thanks, I figured it was just that, but I wasn't sure and didn't want to
mess with lines of code I wasn't that familiar with. I'll use the new
master and generate a new pull request for adding the ability to do an Axis
remap (see Section 3.4 of the data sheet) later this week, as I think it
would be useful to a lot of people.
…On Tue, Apr 6, 2021 at 4:53 PM Dylan Herrada ***@***.***> wrote:
@ViennaMike <https://github.com/ViennaMike> Yeah, so that's a check that
recently got added to pylint. I'll fix that for you since it's something
that I should have done anyway and then just run black.
If you do want to learn more about pylint and black go here:
https://learn.adafruit.com/improve-your-code-with-pylint
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#76 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHXZ3UCKLGJTQQXBANA3C3THNYEVANCNFSM42JPSM4A>
.
|
|
No problem. Sweet. That sounds like a great addition. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Apr 9, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO055 to 5.2.6 from 5.2.5: > Merge pull request adafruit/Adafruit_CircuitPython_BNO055#76 from ViennaMike/fix_fusion_modes > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_AzureIoT to 2.3.5 from 2.3.4: > Moved a function around > Merge pull request adafruit/Adafruit_CircuitPython_AzureIoT#28 from jimbobbennett/master > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_Bitmap_Font to 1.4.0 from 1.3.7: > Merge pull request adafruit/Adafruit_CircuitPython_Bitmap_Font#42 from FoamyGuy/add_forkawesome_example > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Heart_Rate to 1.1.8 from 1.1.7: > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Heart_Rate#13 from adafruit/tannewt-patch-1 > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_iBBQ to 1.2.5 from 1.2.4: > Merge pull request adafruit/Adafruit_CircuitPython_BLE_iBBQ#5 from adafruit/tannewt-patch-1 > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_MIDI to 1.0.5 from 1.0.4: > Merge pull request adafruit/Adafruit_CircuitPython_BLE_MIDI#7 from adafruit/tannewt-patch-1 > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_Debouncer to 1.3.11 from 1.3.10: > Merge pull request adafruit/Adafruit_CircuitPython_Debouncer#27 from adafruit/linting > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_Layout to 1.9.1 from 1.9.0: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#33 from makermelissa/main Updating https://github.com/adafruit/Adafruit_CircuitPython_FeatherWing to 1.14.2 from 1.14.1: > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#71 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_FunHouse to 1.1.0 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_FunHouse#6 from makermelissa/main > Merge pull request adafruit/Adafruit_CircuitPython_FunHouse#5 from makermelissa/main > Merge pull request adafruit/Adafruit_CircuitPython_FunHouse#3 from makermelissa/main Updating https://github.com/adafruit/Adafruit_CircuitPython_HID to 4.3.0 from 4.2.0: > Merge pull request adafruit/Adafruit_CircuitPython_HID#63 from JPEWdev/consumer-press-release Updating https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal to 2.2.2 from 2.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#71 from makermelissa/master > "Increase duplicate code check threshold " Updating https://github.com/adafruit/Adafruit_CircuitPython_MIDI to 1.3.5 from 1.3.4: > Merge pull request adafruit/Adafruit_CircuitPython_MIDI#32 from jepler/update-simpletest Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 0.4.0 from 0.3.0: > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#20 from adafruit/jepler-frequency-too-low > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#17 from gamblor21/mov_operators Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.9.9 from 1.9.8: > Merge pull request adafruit/Adafruit_CircuitPython_Requests#76 from askpatrickw/fix-48 > "Increase duplicate code check threshold "
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #75 that I opened. When doing so, I found that the outputs mismatched what they should be for some additional modes as well, so I fixed them too: