Adding CircuitPython MatrixKeypad library to bundle #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Kattni, I may be using this one in a project this month - a matrix
keypad is one way to control a robot.
…On Mon, Jun 4, 2018 at 7:31 PM, Kattni ***@***.***> wrote:
------------------------------
You can view, comment on, or merge this pull request online at:
#79
Commit Summary
- Adding CircuitPython MatrixKeypad library to bundle
File Changes
- *M* .gitmodules
<https://github.com/adafruit/Adafruit_CircuitPython_Bundle/pull/79/files#diff-0>
(3)
- *A* libraries/matrixkeypad
<https://github.com/adafruit/Adafruit_CircuitPython_Bundle/pull/79/files#diff-1>
(1)
Patch Links:
- https://github.com/adafruit/Adafruit_CircuitPython_Bundle/
pull/79.patch
- https://github.com/adafruit/Adafruit_CircuitPython_Bundle/
pull/79.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#79>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AB0scDSUZIL3HDZofpZ4iScBwThW0Ccjks5t5cNpgaJpZM4UZ7u2>
.
|
caternuson
reviewed
Jun 5, 2018
.gitmodules
Outdated
| @@ -244,3 +244,6 @@ | |||
| [submodule "libraries/drivers/stmpe610"] | |||
| path = libraries/drivers/stmpe610 | |||
| url = https://github.com/adafruit/Adafruit_CircuitPython_STMPE610.git | |||
| [submodule "libraries/matrixkeypad"] | |||
| path = libraries/matrixkeypad | |||
There was a problem hiding this comment.
I think you're missing a level. Try: path = libraries/drivers/matrixkeypad
.gitmodules
Outdated
| @@ -244,3 +244,6 @@ | |||
| [submodule "libraries/drivers/stmpe610"] | |||
| path = libraries/drivers/stmpe610 | |||
| url = https://github.com/adafruit/Adafruit_CircuitPython_STMPE610.git | |||
| [submodule "libraries/matrixkeypad"] | |||
| path = libraries/matrixkeypad | |||
| url = https://github.com/adafruit/Adafruit_CircuitPython_MatrixKeypad | |||
There was a problem hiding this comment.
Not sure how important the .git ending is for the URL, but that's what github gives you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.