-
Notifications
You must be signed in to change notification settings - Fork 8
Add getter and setter for the "Averaging and Sampling Configuration" register #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…register The methods provide (/ accept) a triple containing the three parameters required to fully specify the register: avg, samp_time and cycle_time. This allows the user to tweak the responsiveness of the CAP1188.
@jeremiahrose The checks are failing on this PR. Please check out this guide for the steps necessary to deal with the formatting checks: https://learn.adafruit.com/improve-your-code-with-pylint Let me know if you need any assistance! |
i reviewed for style but not physical test - im ok merging once CI passes! |
Hi @jeremiahrose, would you please run black code formatter on this? It should get to the next stage of checks after that. Thanks |
@ladyada Are you still okay with merging this once CI passes? |
id like someone to test it with hardware first |
@ladyada I'd be willing to, but it'd take a few days since I don't have the hardware. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It did work exactly as it was supposed to, but I do think that it should be reorganized for ease of use and readability.
@dherrada, person involved in this has not longer the hardware to do any development, so I think we have to options:
|
@jposada202020 If you'd like to, take a crack at making those changes and I'll test, but if you don't want to I can make them myself although finals are starting soon for me so I might not be able to get to it for a bit |
No worries Ill take it, No more finals in my life :) @dherrada |
Lucky you lol |
@dherrada I am so sorry for the delay in getting back to you :), in #21 are the changes, if |
@jposada202020 No worries. My only final is Saturday and I'm already decently well prepared for it anyways. |
@jposada202020 Want to test this when your gets in? |
Yes I would! Thanks @dherrada |
Closed. Changes with made after work from @jeremiahrose on PR #21 |
Fixes issue #16
The methods provide (/ accept) a triple containing the three
parameters required to fully specify the register: avg, samp_time
and cycle_time.
This allows the user to tweak the responsiveness of the CAP1188.