Skip to content

Add getter and setter for the "Averaging and Sampling Configuration" register #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

jeremiahrose
Copy link

Fixes issue #16

The methods provide (/ accept) a triple containing the three
parameters required to fully specify the register: avg, samp_time
and cycle_time.
This allows the user to tweak the responsiveness of the CAP1188.

…register

The methods provide (/ accept) a triple containing the three
parameters required to fully specify the register: avg, samp_time
and cycle_time.
This allows the user to tweak the responsiveness of the CAP1188.
@evaherrada evaherrada linked an issue Aug 6, 2020 that may be closed by this pull request
@kattni
Copy link
Contributor

kattni commented Aug 17, 2020

@jeremiahrose The checks are failing on this PR. Please check out this guide for the steps necessary to deal with the formatting checks: https://learn.adafruit.com/improve-your-code-with-pylint Let me know if you need any assistance!

@kattni kattni requested a review from a team August 17, 2020 21:14
@ladyada
Copy link
Member

ladyada commented Aug 17, 2020

i reviewed for style but not physical test - im ok merging once CI passes!

@makermelissa
Copy link
Collaborator

Hi @jeremiahrose, would you please run black code formatter on this? It should get to the next stage of checks after that. Thanks

@evaherrada
Copy link
Collaborator

@ladyada Are you still okay with merging this once CI passes?

@ladyada
Copy link
Member

ladyada commented Nov 24, 2020

id like someone to test it with hardware first

@evaherrada
Copy link
Collaborator

@ladyada I'd be willing to, but it'd take a few days since I don't have the hardware.

Copy link
Collaborator

@evaherrada evaherrada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It did work exactly as it was supposed to, but I do think that it should be reorganized for ease of use and readability.

@jposada202020
Copy link
Contributor

@dherrada, person involved in this has not longer the hardware to do any development, so I think we have to options:

  1. Accept the PR as is, something that you don not like very much
  2. I could do the changes that you mentioned, however I do not have this hardware. So testing needs to be done by other folk.
    What do you think?

@evaherrada
Copy link
Collaborator

@jposada202020 If you'd like to, take a crack at making those changes and I'll test, but if you don't want to I can make them myself although finals are starting soon for me so I might not be able to get to it for a bit

@jposada202020
Copy link
Contributor

No worries Ill take it, No more finals in my life :) @dherrada

@evaherrada
Copy link
Collaborator

Lucky you lol

@jposada202020
Copy link
Contributor

@dherrada I am so sorry for the delay in getting back to you :), in #21 are the changes, if soon does not mean starting tomorrow, I think we are good to go. thanks 👍🏼

@evaherrada
Copy link
Collaborator

@jposada202020 No worries. My only final is Saturday and I'm already decently well prepared for it anyways.

@evaherrada
Copy link
Collaborator

@jposada202020 Want to test this when your gets in?

@jposada202020
Copy link
Contributor

Yes I would! Thanks @dherrada

@jposada202020
Copy link
Contributor

Closed. Changes with made after work from @jeremiahrose on PR #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for averaging and sample time register
6 participants