Skip to content

Fixed link #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 2, 2019
Merged

Fixed link #28

merged 1 commit into from
Feb 2, 2019

Conversation

Tim-Jackins
Copy link
Contributor

No description provided.

makermelissa
makermelissa reviewed Feb 2, 2019
View reviewed changes
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself looks good. Travis is failing on some example file saying that PWMOut is not a member of pulsio. I'm not quite sure what that's about. Anybody have any insight into that?

@dhalbert
Copy link
Contributor

dhalbert commented Feb 2, 2019

I looked at this and couldn't replicate it locally. However, I think it might be because Adafruit-Blinka provides a pulseio that doesn't have PWMOut unless it's running on an RPi.

The fix might be to add pulseio to this line:
https://github.com/adafruit/Adafruit_CircuitPython_CharLCD/blob/master/.pylintrc#L158

ignored-modules=board

@ladyada
Copy link
Member

ladyada commented Feb 2, 2019

oh yeah , i haven't done a libgpiod PWMOut yet (e.g. bitbanged pwm on raspi) :/

@kattni
Copy link
Contributor

kattni commented Feb 2, 2019

Ah, ok! That makes sense.

makermelissa
makermelissa approved these changes Feb 2, 2019
View reviewed changes
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@makermelissa makermelissa merged commit e4ccef3 into adafruit:master Feb 2, 2019
@ladyada
Copy link
Member

ladyada commented Feb 2, 2019

👍 teamwork :)

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Feb 3, 2019
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@6bdf304)
9d93ee1 
Updating https://github.com/adafruit/Adafruit_CircuitPython_CharLCD to 3.1.1 from 3.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_CharLCD#28 from Tim-Jackins/master
  > Merge pull request adafruit/Adafruit_CircuitPython_CharLCD#30 from adafruit/ladyada-patch-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makermelissa makermelissa makermelissa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Tim-Jackins @dhalbert @ladyada @kattni @makermelissa