Annotation fixes in circuitplayground_base and bluefruit.py

[tcfranks]

No description provided.

[tcfranks]

LMK how this looks....

[tekktrik]

Thanks for the submission! I added my feedback below, let me know if you have any questions!

[tcfranks]

wow, that was a lot to take in. pylint is throwing complaints about line endings, but the last big one it's choking on is:
adafruit_circuitplayground\circuit_playground_base.py:149:26: E1101: Module 'os' has no 'uname' member; maybe 'name'? (no-member)
which refers to this line:
if (
"nRF52840" in os.uname().machine

Clearly uname() returns a namedtuple that includes machine, so why is pylint kicking this out? Any suggestions?

[tekktrik]

CPython uses os.name but CircuitPython uses os.uname. We could disable it at that point, but I wonder if pylint stops complaining once the typing stubs are imported (something the CI may do).

When you push code, git should be fixing the line endings for you. They are different between Linux and Windows, so my guess is that you're developing on windows where the line ending is CRLF, but git prefers LF. If you push the code, it should get automatically resolved, and then I can give it another review, as well as see whether that remaining pylint error goes away.

[Neradoc]

CPython uses os.name but CircuitPython uses os.uname. We could disable it at that point, but I wonder if pylint stops complaining once the typing stubs are imported (something the CI may do).

Note that os.uname is C python: https://docs.python.org/3/library/os.html#os.uname
It's a little weird though, it's not available on windows, only Unix, so that might be the issue here. Or pylint is being weird.

[tekktrik]

Oh neat, good point, and thanks for that correction! I think pylint can also lint based on your version of Python (won't flag things if it was added in a later version of Python), so it may be something similar with regards to the operating system.

It sounds like this might just be a good time to push the code to this branch and see what still remains to be done. We can even give those suggestions as comments to the lines.

[tekktrik]

Nice! A few more things and then this should be good to go!

[tekktrik]

These uses of ticks (`) are used intentionally for formatting, you should change this and the other ones below back to that so the formatting and links will show appropriately.

[tekktrik]

It looks like these should be reverted back to ticks (`)

[tcfranks]

I thought I did? tick to the left of #1 ?

[tekktrik]

Here it should be reverted back to:

Suggested change

	'adafruit_circuitplayground.circuit_playground_base'
	`adafruit_circuitplayground.circuit_playground_base`

[tekktrik]

Few more changes but should be good after that!

[tekktrik]

I always forget that Literal wasn't added to typing until Python 3.8. Since we support Python 3.7 as the minimum version, which means for development as well, let's import it Literal from typing_extensions instead. You can remove the Literal import here and add this as a line below:

    from typing_extensions import Literal

Make sure you add typing-extensions~=4.0 as a dependency in setup.py and requirements.txt to ensure it gets downloaded as well. Let me know if you need help doing that.

[tcfranks]

clue about setup.py would be nice. All I see is setup.py.disabled. Is that because of Pycharm?

[tekktrik]

You'll need to update this branch to the latest main branch, that file has been deleted and since replaced with setup.py in a recent pull request.

[tcfranks]

yeah, got that update now. is it added as just a simple import in setup.py? or some other way?

[tekktrik]

You add it to the list of install_requires in setup()

    install_requires=[
        "adafruit-circuitpython-lis3dh",
        "adafruit-circuitpython-thermistor",
        "adafruit-circuitpython-neopixel",
        "typing-extensions~=4.0",
    ],

[tcfranks]

it threw a number error after adding this line, and went back to just dying when I removed "~=4.0". All pylint is showing me locally is that it does not like the uname function of os, in addition to the line ending errors.

Not sure if you can see what specifically is choking it here.....

[tekktrik]

It looks like these should be reverted back to ticks (`)

[tekktrik]

Looks like you'll need to run pre-commit, fix setup.py, and revert to using those tick marks!

[tcfranks]

hmmm
black didn't like requirements.txt
the process didn't like the way black changed it.
I put the important bits back they way they were and re-checked it and apparently all is good. LMK

[tcfranks]

also, I run pylint and black manually. I downloaded and installed precommit but for some reason on my windows box it won't run as a unit, in spite of having looked at path, etc. any ideas, besides running linux? :)

[tcfranks]

oh duh. well - I think I just solved the pre-commit problem.....we'll see next time I need to use it.