Added speaker tones to Circuit Playground Express CircuitPython API. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Included image for docs.
tannewt
requested changes
Sep 18, 2017
| @@ -63,6 +66,10 @@ def __init__(self): | |||
| self._temp = adafruit_thermistor.Thermistor(board.TEMPERATURE, 10000, 10000, 25, 3950) | |||
| self._light = Photocell(board.LIGHT) | |||
|
|
|||
| # Define audio: | |||
| self.speaker_enable = digitalio.DigitalInOut(board.SPEAKER_ENABLE) | |||
| self.speaker_enable.switch_to_output(value=True) | |||
There was a problem hiding this comment.
Lets not set the value to True until we want to play sound. Otherwise the speaker will crackle randomly.
| def play_tone(self, frequency, duration): | ||
| """ Produce a tone using the speaker. | ||
|
|
||
| .. image :: /_static/speaker.jpg |
There was a problem hiding this comment.
Empty lines are weirdly important so you'll need one after the image line and after the paragraph below.
| sine_wave[i] = int(math.sin(math.pi * 2 * i / 18) * (2 ** 15) + 2 ** 15) | ||
|
|
||
| sample = audioio.AudioOut(board.SPEAKER, sine_wave) | ||
|
|
There was a problem hiding this comment.
Add the speaker enable toggle here and after stop.
| @@ -184,6 +191,30 @@ def red_led(self): | |||
| def red_led(self, value): | |||
| self._led.value = value | |||
|
|
|||
| def play_tone(self, frequency, duration): | |||
| """ Produce a tone using the speaker. | |||
|
|
|||
There was a problem hiding this comment.
Please document the two arguments frequency and duration using the param style here: https://github.com/adafruit/Adafruit_CircuitPython_DotStar/blob/master/adafruit_dotstar.py#L39
Python only associates comments with the method itself when they are the first thing in the method. Also add param types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included image for docs.