Add timing properties as per ATMakersBill's suggestion #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My only comment would be to add an example that uses the duration properties. Otherwise, this is great. |
dastels
changed the title
|
Where is the context for this PR? I'm ok adding this but would love to understand the motivation before doing the review. |
|
@tannewt This was a request from @ATMakersBill: to give timing information to make it easier to detect short vs long presses (for example). |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Nov 19, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_CircuitPlayground to 2.1.5 from 2.1.4: > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#73 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#72 from dherrada/master > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#70 from dcbriccetti/tilt-instrument Updating https://github.com/adafruit/Adafruit_CircuitPython_GPS to 3.5.1 from 3.5.0: > Merge pull request adafruit/Adafruit_CircuitPython_GPS#37 from kattni/setup-py-update Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM9DS1 to 2.0.5 from 2.0.4: > Merge pull request adafruit/Adafruit_CircuitPython_LSM9DS1#17 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_LSM9DS1#16 from 2bndy5/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Debouncer to 1.1.0 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_Debouncer#12 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_Debouncer#11 from dastels/master Updating https://github.com/adafruit/Adafruit_CircuitPython_HID to 3.3.6 from 3.3.5: > Merge pull request adafruit/Adafruit_CircuitPython_HID#41 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_HID#42 from adafruit/revert-40-alternate-devices-for-ble > Merge pull request adafruit/Adafruit_CircuitPython_HID#40 from dhalbert/alternate-devices-for-ble Updating https://github.com/adafruit/Adafruit_CircuitPython_MIDI to 1.1.1 from 1.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_MIDI#13 from kevinjwalters/master > Merge pull request adafruit/Adafruit_CircuitPython_MIDI#16 from adafruit/dherrada-patch-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.