Added value checks for "rect" and "roundrect" #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoamyGuy
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
Looks good to me.
I added one commit with changes that the CI formatter was upset about.
Thanks for the improved error handling @Ashtreighlia!
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Aug 24, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Shapes to 2.7.0 from 2.6.2: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Shapes#62 from Ashtreighlia/main Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue description
I encountered some bugs that were caused by user input errors (e.g. automatically assigning widths and heights => 0), leading to issues that were challenging to diagnose due to the lack of clear error messages. To address this, I have added checks for the "rect" and "roundrect" functions.
Added checks
These checks aim to ensure the correctness of incoming values and provide error messages if they are out-of-spec.