Skip to content

Changing logic to include tab replacement and glyph calculation #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Changing logic to include tab replacement and glyph calculation #121

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d99d16f
Changing logic to include tab replacement and glyph calculation
jposada202020 Feb 20, 2021
c7b6fd2
adding text treatment to address corner case when max_glyphs values i…
jposada202020 Feb 20, 2021
8c2a73b
Including review regarding text logic in if statement
jposada202020 Feb 23, 2021
90f2973
Black and Pylint
jposada202020 Feb 23, 2021
2e860cc
Addding tab verification when setter is called
jposada202020 Feb 25, 2021
cbc5963
Tab verification for Bitmap Label
jposada202020 Feb 25, 2021
71270ce
New parameter to include the possibility to define the number a type …
jposada202020 Feb 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions adafruit_display_text/label.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,9 @@ def __init__(
if not max_glyphs and not text:
raise RuntimeError("Please provide a max size, or initial text")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could save a line and just put the text = " ".join(text.split("\t")) before the if not max_glyphs: statement.

It does this calculation either way, so just do it once and then do the max_glyphs check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback, good point, I will change it and re-do the test just to be 100% sure. Thanks @kmatch98 :)

if not max_glyphs:
text = " ".join(text.split("\t"))
max_glyphs = len(text)
text = " ".join(text.split("\t"))
# add one to max_size for the background bitmap tileGrid

# instance the Group
Expand Down