dont forget set frequency (as we dont use busdevice) #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sommersoft
approved these changes
Sep 28, 2019
|
lol |
dcbriccetti
reviewed
Sep 28, 2019
| @@ -71,6 +71,11 @@ def __init__(self, width, height, spi, cs_pin, dc_pin, sramcs_pin, rst_pin, busy | |||
|
|
|||
| # SPI interface (required) | |||
| self.spi_device = spi | |||
| while not self.spi_device.try_lock(): | |||
| pass | |||
| self.spi_device.configure(baudrate=1000000) # 1 Mhz | |||
There was a problem hiding this comment.
On the small chance you don’t know about the feature (and in spite of the fact that this is already merged), I’ll mention that 1_000_000 is easier to read than 1000000.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Oct 20, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO055 to 4.0.0 from 3.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_BNO055#38 from dherrada/master Updating https://github.com/adafruit/Adafruit_CircuitPython_EPD to 2.4.2 from 2.4.1: > Merge pull request adafruit/Adafruit_CircuitPython_EPD#31 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_EPD#28 from ladyada/master > Merge pull request adafruit/Adafruit_CircuitPython_EPD#27 from ladyada/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this came up with the ft232h cause we need to give it some default