Don't print password by default in debug #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
Apr 26, 2023
| @@ -563,17 +563,23 @@ def connect(self, secrets): | |||
| that contains a 'ssid' and 'password' entry""" | |||
| self.connect_AP(secrets["ssid"], secrets["password"]) | |||
|
|
|||
| def connect_AP(self, ssid, password, timeout_s=10): # pylint: disable=invalid-name | |||
| def connect_AP( | |||
| self, ssid, password, timeout_s=10, show_password=False | |||
There was a problem hiding this comment.
I'd rather not have the kwarg here. I think it should go next to the debug flag. It could be debug_show_secrets to cover other sorts of keys in addition to the password.
There was a problem hiding this comment.
Good thinking! To be clear, you're suggesting it should be an init param?
FoamyGuy
approved these changes
Apr 26, 2023
There was a problem hiding this comment.
Thanks for working on this @zachariahpifer!
The latest version of this looks good to me. I haven't tested on hardware. Will try it out in the next few days if it's still open.
tannewt
approved these changes
Apr 27, 2023
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jun 23, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 5.0.6 from 5.0.5: > Update .pylintrc, fix jQuery for docs > Run pre-commit > Update pre-commit hooks > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#178 from zachariahpifer/dont_print_password_in_debug > Add upload url to release action > Add .venv to .gitignore > Update .pylintrc for v2.15.5 > Fix release CI files > Update pylint to 2.15.5 > Updated pylint version to 2.13.0 > Switching to composite actions Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #156