fix UDP handling #59
Merged
fix UDP handling #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me. One question: did you also re-test TCP after these changes? |
|
I retested after the first commit, but not after the other two. I will do that on Monday. |
|
I retested with TCP (e.g. localtime example) and can confirm it works. BTW: you can find my UDP test-program here: https://github.com/bablokb/circuitpython-examples/ (subdirectory esp01-udplogger). Switching to TCP is simply done by changing |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jun 6, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP_ATcontrol to 0.6.8 from 0.6.7: > Merge pull request adafruit/Adafruit_CircuitPython_ESP_ATcontrol#59 from bablokb/udpfix > Set language to "en" for documentation > Switch to inclusive terminology > Increase min lines similarity > Merge pull request adafruit/Adafruit_CircuitPython_ESP_ATcontrol#57 from tekktrik/doc/fix-readme > Patch .pre-commit-config.yaml > Add support warning to README.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a fix for #58. Tested with an ESP01S and a Pico against
netcat -u -l <portnr>:socket_connect()saves the connection type as an object attribute and fixes at_response handlingsocket_send()does not try to read a response (there is no response with UDP), this saves some mssocket_disconnect()resets saved connection-type