Skip to content

Fixed issue #11 #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from
Closed

Fixed issue #11 #12

wants to merge 14 commits into from

Conversation

devoh747
Copy link
Contributor

@devoh747 devoh747 commented Oct 7, 2019

Import of fancy_led was causing
Traceback (most recent call last):
File "code.py", line 21, in
File "/home/travis/build/adafruit/Adafruit_CircuitPython_Bundle/libraries/helpers/fancyled/adafruit_fancyled/fastled_helpers.py", line 111, in loadDynamicGradientPalette
AttributeError: 'module' object has no attribute 'CRGB'

Import of fancy_led was causing
Traceback (most recent call last):
  File "code.py", line 21, in <module>
  File "/home/travis/build/adafruit/Adafruit_CircuitPython_Bundle/libraries/helpers/fancyled/adafruit_fancyled/fastled_helpers.py", line 111, in loadDynamicGradientPalette
AttributeError: 'module' object has no attribute 'CRGB'
@devoh747
Copy link
Contributor Author

devoh747 commented Oct 7, 2019

On a CPX with CP 4.1.0 and lib 4.x from 10/4

https://github.com/adafruit/Adafruit_CircuitPython_FancyLED/blob/master/examples/fancyled_cpx_helper_example.py was failing with a

Traceback (most recent call last):
File "code.py", line 21, in
File "/home/travis/build/adafruit/Adafruit_CircuitPython_Bundle/libraries/helpers/fancyled/adafruit_fancyled/fastled_helpers.py", line 111, in loadDynamicGradientPalette
AttributeError: 'module' object has no attribute 'CRGB'

import adafruit_fancyled as fancy

was causing a 
Traceback (most recent call last):
  File "code.py", line 21, in <module>
  File "/home/travis/build/adafruit/Adafruit_CircuitPython_Bundle/libraries/helpers/fancyled/adafruit_fancyled/fastled_helpers.py", line 111, in loadDynamicGradientPalette
AttributeError: 'module' object has no attribute 'CRGB'
@devoh747 devoh747 closed this Oct 8, 2019
@devoh747
Copy link
Contributor Author

devoh747 commented Oct 8, 2019

I did absolute patch wrong. Will open new PR.

@devoh747
Copy link
Contributor Author

devoh747 commented Oct 8, 2019

Reopening this PR with correct import statement

@devoh747 devoh747 reopened this Oct 8, 2019
@caternuson caternuson requested a review from a team October 8, 2019 00:42
@theacodes theacodes mentioned this pull request Oct 9, 2019
Zero length
@devoh747
Copy link
Contributor Author

devoh747 commented Oct 9, 2019

Closing as this is a mess and entered wrong.. I am using this as a learning experience. I opened a new PR #14 that has the fix nice and cleanly. Please ignore this PR #12

@devoh747 devoh747 closed this Oct 9, 2019
@caternuson caternuson removed the request for review from a team October 9, 2019 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants