Skip to content

Update slider cap_map #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2021
Merged

Update slider cap_map #15

merged 1 commit into from
May 24, 2021

Conversation

lesamouraipourpre
Copy link
Contributor

Ref: https://forums.adafruit.com/viewtopic.php?f=59&t=179496#p874102

RufusVS2020 said:

(change 0x05 to 0x06)
The code is designed to track when you are pressing a single contact or two adjacent contacts. If you take the binary of
the values, you should have a single bit or two adjacent bits. The binary for 0x05 is 0b00101 which clearly does not have
the required adjacent bits. 0x06 is 0b00110 which is the correct pattern.

I don't have a FunHouse to test with but this has been reported working on the AdaFruit Forums and the issue was just reappeared on Discord.

@ladyada ladyada requested a review from makermelissa May 24, 2021 13:53
makermelissa
makermelissa approved these changes May 24, 2021
View reviewed changes
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, yeah. This change is correct. Thanks. :)

@makermelissa makermelissa merged commit 6233047 into adafruit:main May 24, 2021
@lesamouraipourpre lesamouraipourpre deleted the patch-1 branch May 24, 2021 16:02
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request May 25, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@8da89ce)
3473043 
Updating https://github.com/adafruit/Adafruit_CircuitPython_OV to 1.0.1 from 1.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_OV#7 from adafruit/linting
  > Added pull request template

Updating https://github.com/adafruit/Adafruit_CircuitPython_RPLIDAR to 1.2.1 from 1.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_RPLIDAR#19 from zlite/patch-1
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template

Updating https://github.com/adafruit/Adafruit_CircuitPython_Seesaw to 1.8.3 from 1.8.2:
  > Moved CI to Python 3.7
  > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#68 from lesamouraipourpre/version
  > Added help text and problem matcher
  > Added pull request template

Updating https://github.com/adafruit/Adafruit_CircuitPython_FunHouse to 2.1.2 from 2.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_FunHouse#15 from lesamouraipourpre/patch-1
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladyada ladyada ladyada approved these changes

@makermelissa makermelissa makermelissa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lesamouraipourpre @ladyada @makermelissa