Skip to content

Added rotation support and simplified TFT Gizmo code #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 4, 2019

Conversation

makermelissa
Copy link
Collaborator

Fixes #7

@makermelissa makermelissa requested a review from a team December 4, 2019 19:59
@ladyada
Copy link
Member

ladyada commented Dec 4, 2019

nice cleanup!

@makermelissa
Copy link
Collaborator Author

Interesting error:

Warning, treated as error:
autodoc: failed to import module 'tft_gizmo' from module 'adafruit_gizmo'; the following exception was raised:
Traceback (most recent call last):
  File "/home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/sphinx/ext/autodoc/importer.py", line 32, in import_module
    return importlib.import_module(modname)
  File "/home/travis/virtualenv/python3.6.7/lib/python3.6/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 994, in _gcd_import
  File "<frozen importlib._bootstrap>", line 971, in _find_and_load
  File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 665, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 678, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/travis/build/adafruit/Adafruit_CircuitPython_Gizmo/adafruit_gizmo/tft_gizmo.py", line 40, in <module>
    class TFT_Gizmo(ST7789):
  File "/home/travis/build/adafruit/Adafruit_CircuitPython_Gizmo/adafruit_gizmo/tft_gizmo.py", line 43, in TFT_Gizmo
    def __init__(self, *, spi=None, cs=board.RX, dc=board.TX,
AttributeError: module 'board' has no attribute 'RX'
The command "cd docs && sphinx-build -E -W -b html . _build/html && cd .." exited with 2.

I wonder if Blinka might need this added just so it can test this.

@makermelissa makermelissa merged commit 109182c into adafruit:master Dec 4, 2019
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Dec 5, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_Gizmo to 1.1.1 from 1.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Gizmo#8 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_PyBadger to 0.9.3 from 0.9.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#10 from CedarGroveStudios/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_NeoPixel_SPI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add rotation support to TFT Gizmo
2 participants