update contributed sonar library to make even better! #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
Sep 7, 2018
adafruit_hcsr04.py
Outdated
| if isinstance(trig_pin, str): | ||
| trig_pin = getattr(board, trig_pin) | ||
| if isinstance(trigger_pin, str): | ||
| trigger_pin = getattr(board, trigger_pin) | ||
| if isinstance(echo_pin, str): | ||
| echo_pin = getattr(board, echo_pin) |
There was a problem hiding this comment.
How about removing this. It adds a second way to do something that will be confusing.
adafruit_hcsr04.py
Outdated
| # method on instantiation. | ||
| pass | ||
| if self._trig is not None: | ||
| return self._dist_two_wire() |
There was a problem hiding this comment.
How does it throw the runtime exception? A missing return is return None implicitly.
There was a problem hiding this comment.
at this time we only support two_wire so ill just remove the if() and we'll add one-wire later if i can find a PING sensor
tekktrik
pushed a commit
that referenced
this pull request
Sep 16, 2022
keep _USE_PULSEIO false for NotImplementedError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now uses the
distanceproperty for standard cm output, and works with both pulseio and non-pulseio boards, like Raspberry Pi (e.g. linux)