Skip to content

Add familiar Mac and Windows names for GUI and ALT keys. #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2018

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Nov 1, 2018

Add Keycode names that correspond to Mac and Windows keyboard labels, for more obvious use without having to refer to the documentation.

  • Add Keycode.WINDOWS and Keycode.COMMAND as aliases for Keycode.GUI.
  • Add Keycode.OPTION as alias for Keycode.ALT.

I want to get this in before I freeze the latest lib versions for CPy 3.1.0.

@dhalbert dhalbert requested a review from a team November 1, 2018 17:31
Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for adding this!

@dhalbert
Copy link
Collaborator Author

dhalbert commented Nov 1, 2018

Tested on a Mac and on Linux (which uses the WINDOWS key).

@kattni kattni merged commit f5e70e0 into adafruit:master Nov 1, 2018
tannewt pushed a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Nov 2, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_CircuitPlayground to 2.0.4 from 2.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#42 from dhalbert/frozen-order

Updating https://github.com/adafruit/Adafruit_CircuitPython_Crickit to 2.1.2 from 2.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_Crickit#10 from dhalbert/frozen-order
  > ignore the board module imports in .pylintrc

Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3DH to 4.3.3 from 4.3.2:
  > Update spinner_advanced.py
  > Merge pull request adafruit/Adafruit_CircuitPython_LIS3DH#47 from adafruit/ladyada-patch-2

Updating https://github.com/adafruit/Adafruit_CircuitPython_Thermistor to 3.2.1 from 3.2.0:
  > ignore the board module imports in .pylintrc

Updating https://github.com/adafruit/Adafruit_CircuitPython_BusDevice to 2.2.6 from 2.2.5:
  > ignore the board module imports in .pylintrc

Updating https://github.com/adafruit/Adafruit_CircuitPython_HID to 3.3.0 from 3.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_HID#27 from dhalbert/gui-alt-key-aliases

Updating https://github.com/adafruit/Adafruit_CircuitPython_Motor to 1.3.2 from 1.3.1:
  > ignore the board module imports in .pylintrc
@dhalbert dhalbert deleted the gui-alt-key-aliases branch April 8, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants