Skip to content

Correct errors and omissions in keycode docstrings #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2017

Conversation

dhalbert
Copy link
Collaborator

This just corrects and clarifies a few of the keycode docstrings. In particular, the keyname for a Mac key was wrong. No functionality changes.

@tannewt
Copy link
Member

tannewt commented May 24, 2017

Instead of merging to update to upstream, please use rebase (git rebase -i adafruit/master). Without that, it'll keep your merge commit in addition to the merge for the pull request.

@tannewt tannewt self-requested a review May 24, 2017 05:30
@dhalbert
Copy link
Collaborator Author

dhalbert commented May 24, 2017

Sure -done. We rarely rebase at work; gotta get used to it. Next time I should use a branch so I don't need to merge my github fork master with the upstream master.

@tannewt
Copy link
Member

tannewt commented May 24, 2017

Perfect, thanks! I prefer rebase until merging into the "don't rewrite me" master branch.

@tannewt tannewt merged commit 7efdc17 into adafruit:master May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants