Convert signed mouse values to 8-bit unsigned values for report #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caternuson
approved these changes
May 23, 2019
|
Tested and works. Adafruit CircuitPython 4.0.1 on 2019-05-22; Adafruit ItsyBitsy M4 Express with samd51g19
>>> from adafruit_hid.mouse import Mouse
>>> mouse = Mouse()
>>> mouse.move(y=-10)
>>> mouse.move(y=-20)
>>> mouse.move(x=-100, y=-20)
>>> |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
May 24, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 3.0.3 from 3.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#35 from tannewt/group_subscr Updating https://github.com/adafruit/Adafruit_CircuitPython_HID to 3.3.4 from 3.3.3: > Merge pull request adafruit/Adafruit_CircuitPython_HID#38 from dhalbert/mouse-report-bytes > Merge pull request adafruit/Adafruit_CircuitPython_HID#35 from schlafa/patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_HID#33 from jpecor/patch-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37. Now that we're doing bounds checking on stores in bytearrays, the values stored must be unsigned, so mask negative values to 8 bits unsigned.