consumer control code: update link to HID usage tables #55
Conversation
| @@ -33,7 +33,7 @@ class Keycode: | |||
| """USB HID Keycode constants. | |||
|
|
|||
| This list is modeled after the names for USB keycodes defined in | |||
| https://www.usb.org/sites/default/files/documents/hut1_12v2.pdf#page=53. | |||
There was a problem hiding this comment.
I pasted https://www.usb.org/sites/default/files/documents/hut1_12v2.pdf#page=53 and it went to the document and page I expected (screenshot below). Could you check this again?
adafruit_hid/keycode.py
Outdated
| @@ -33,7 +33,7 @@ class Keycode: | |||
| """USB HID Keycode constants. | |||
|
|
|||
| This list is modeled after the names for USB keycodes defined in | |||
| https://www.usb.org/sites/default/files/documents/hut1_12v2.pdf#page=53. | |||
| https://www.usb.org/sites/default/files/hut1_21_0.pdf#page=118. | |||
There was a problem hiding this comment.
This is the newer version of the other document, and the page. It's the Keyboard/Keypad Page (0x07). 118 is the Consumer Control codes page.
|
Oh, I'm sorry I modified the wrong file. The consumer control codes point to http://www.usb.org/developers/hidpage/Hut1_12v2.pdf#page=75 which is not available (anymore?). I'll update the PR. |
schneider42
force-pushed
the
update-hut-link
branch
from
46fc6c5 to
bce0660
Compare
schneider42
changed the title
|
Ah looks like they changed name and location of that PDF. The version referenced in the file now lives under https://www.usb.org/sites/default/files/documents/hut1_12v2.pdf#page=75 The latest version seems to be https://www.usb.org/sites/default/files/hut1_21_0.pdf#page=118 Let me know which one you prefer. |
|
Certainly let's use the latest version of the document. But could you fix both links, both the keyboard codes and the consumer control codes? The page in the new document for keyboard codes is https://www.usb.org/sites/default/files/hut1_21_0.pdf#page=82.
|
|
Will do |
|
Darn. I found this in the middle of submitting a pull request for the same issue. The Keyboard codes are also on PDF page 83, print page 82. https://www.usb.org/sites/default/files/hut1_21_0.pdf#page=83 |
|
This seems to have lost steam. I suggest that this is what needs to be done:
The commit of @schneider42 already addresses the first one. The second one is me concurring with the recent comment of @steamfoundry. |
There was a problem hiding this comment.
Thanks @schneider42, @steamfoundry, and @silverman for your work and comments. I consolidated everything, fixed both links, and merged from upstream.
Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 5.1.0 from 5.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#102 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#101 from jfurcean/fix-secrets-import Updating https://github.com/adafruit/Adafruit_CircuitPython_HID to 4.1.5 from 4.1.4: > Merge pull request adafruit/Adafruit_CircuitPython_HID#55 from schneider42/update-hut-link > Merge pull request adafruit/Adafruit_CircuitPython_HID#56 from adafruit/REUSE > Added pre-commit-config file > Added pre-commit and SPDX copyright Updating https://github.com/adafruit/Adafruit_CircuitPython_MotorKit to 1.6.0 from 1.5.4: > Merge pull request adafruit/Adafruit_CircuitPython_MotorKit#38 from adafruit/REUSE > Merge pull request adafruit/Adafruit_CircuitPython_MotorKit#37 from CedarGroveStudios/pwm-freq-get-set > Added pre-commit-config file > Added pre-commit and SPDX copyright Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_SHT4x
The old file was not available anymore. I believe this is where it was pointing at in the document.