Skip to content

Fixed Flicker for Numbers when Autowrite is on #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 30, 2019

Conversation

makermelissa
Copy link
Collaborator

Fixed Flicker for Numbers when Autowrite is on

See #29

@makermelissa
Copy link
Collaborator Author

I also tested that this didn't break the work I did for Adafruit_CircuitPython_FeatherWing.

Note: This was only tested on the 14-Segment display as that's all I have at the moment.

@caternuson
Copy link
Contributor

That will cover it for an actual number input:

disp.print(1234)

but not for string:

disp.print("1234")

Take a look at how print() routes to either _text or _number. For a string entry, it goes straight to _text and would bypass the auto_write disable in _number.

How about:

  • remove auto_write lines from _put in all classes
  • add them to end of __setitem__

@makermelissa
Copy link
Collaborator Author

makermelissa commented Jan 30, 2019

Yeah, I especially noticed it with the numbers. I'll go ahead and experiment with it some more and write a little test script that can work for strings too. Something along the lines of:

count = 1000
while count < 9000:
    count += 1 
    display.print("{}".format(count))
    time.sleep(0.1)

That should make any flickering pretty evident.

@makermelissa
Copy link
Collaborator Author

I did as you suggested and it looks good so far. I want to test some more before I call it good.

@caternuson
Copy link
Contributor

Cool. Ping me when you're ready for another look. I've got the other displays and can test them.

@makermelissa
Copy link
Collaborator Author

Yep @caternuson. It's ready for you to take another look.

@caternuson
Copy link
Contributor

Let's good. Tested and working on a 7 segment.

Thanks for the fix.

@caternuson caternuson merged commit 850a23c into adafruit:master Jan 30, 2019
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jan 30, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP_ATcontrol to 0.2.2 from 0.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP_ATcontrol#23 from jerryneedell/jerryn_examples
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP_ATcontrol#16 from brentru/particle-webcl-simpletest
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP_ATcontrol#22 from jerryneedell/jerryn_ping
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP_ATcontrol#19 from ladyada/master
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP_ATcontrol#18 from jerryneedell/jerryn_post_requests
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP_ATcontrol#17 from ladyada/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_HT16K33 to 2.1.3 from 2.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#30 from makermelissa/flicker-fix

Updating https://github.com/adafruit/Adafruit_CircuitPython_FeatherWing to 1.1.1 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#23 from makermelissa/master
  > Merge pull request adafruit/Adafruit_CircuitPython_FeatherWing#21 from makermelissa/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants