-
Notifications
You must be signed in to change notification settings - Fork 32
Add buffer size property #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
fbd53b0
44b9b01
fb1e6d1
f4e01bf
6528b68
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,6 +30,7 @@ def base(request): # pylint: disable=unused-argument | |
|
||
while True: | ||
try: | ||
# do something useful in this section | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It make be helpful to give an example of what you mean by "something useful", like "operate hardware" or something. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should be easy to add some more details to that comment. |
||
# processing any waiting requests | ||
server.poll() | ||
except OSError: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Snake case will make this a little more readable:
Same thing for the setter of course!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the snake case and it's definitely easier to read. I wasn't sure if there were naming standards, so I just mirrored the other function names. I come from a camel case background, but that doesn't seem to apply in python except in class names.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup! You've got it spot on. I don't think I've ever seen it explicitly said about the project, but generally we follow the PEP8 style guide (unless what we're making a library that should mirror CPython API like how
adafruit_logging
mirrors CPython'slogging
modules but that doesn't follow PEP8 itself).