Skip to content

improving docs, adding .idea to gitignore #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2021
Merged

improving docs, adding .idea to gitignore #15

merged 1 commit into from
Apr 17, 2021

Conversation

jposada202020
Copy link
Contributor

As title describes

Built locally to verify

@jposada202020 jposada202020 requested a review from a team April 16, 2021 23:32
@ladyada ladyada merged commit c6c7078 into adafruit:master Apr 17, 2021
@jposada202020 jposada202020 deleted the improving_docs branch April 17, 2021 03:09
@jepler
Copy link

jepler commented Apr 18, 2021

I don't know what ".idea" is, so this is based on my guess, but: please consider: for files created by your particular development environment, you can put the patterns in a "global ignore" file so that they are ignored in every git repository you place on your system.

One philosophy of .gitignore is that the project one is for files created by interacting with the project in "the standard way", like building and testing the software. An advantage of this philosophy is that it's not scalable to put the patterns for every development environment in every git repo, especially since having many patterns can slow git down (though this is much better than it used to be, at least on linux), and you don't have to make a special request in each project you want to contribute to!

In the CircuitPython modules, we like for all the various files like .gitignore, .github/workflows/build.yml, etc., to have exactly the same content whenever possible, so that doing mass updates of these files can be done by simple patches, so we also think it could reduce effort for us in the long run.

For more details and how-to, see https://stackoverflow.com/questions/7335420/global-git-ignore https://docs.github.com/en/github/getting-started-with-github/ignoring-files#configuring-ignored-files-for-all-repositories-on-your-computer and other resources that an internet search can find!

@kattni
Copy link
Contributor

kattni commented Apr 20, 2021

To clarify, @jposada202020 @jepler, .idea is the directory created when you start PyCharm from within a working directory. I use PyCharm, and am definitely responsible for adding it to some of the libraries. It is fine to add it for now if you run into it.

I am going to file an issue on cookiecutter to suggest updating our .gitignore to include the additional files added by popular IDEs, as we are running into this more often with more diverse folks contributing to the libraries. I feel we would benefit from a more robust .gitignore so folks are not forced to deal with these things locally.

@jposada202020
Copy link
Contributor Author

@kattni thanks for the comments. will do

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Apr 27, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_ADT7410 to 1.2.6 from 1.2.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_ADT7410#16 from jposada202020/adding_board.I2C_reference
  > Merge pull request adafruit/Adafruit_CircuitPython_ADT7410#15 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_AHTx0 to 1.0.6 from 1.0.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_AHTx0#6 from jposada202020/adding_board.I2C_reference
  > Merge pull request adafruit/Adafruit_CircuitPython_AHTx0#5 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_AM2320 to 1.2.7 from 1.2.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_AM2320#20 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_AS7341 to 1.1.0 from 1.0.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_AS7341#14 from jposada202020/removing_reset_function
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_BH1750 to 1.0.5 from 1.0.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_BH1750#2 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_BME680 to 3.3.3 from 3.3.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_BME680#41 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_BMP280 to 3.2.8 from 3.2.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_BMP280#31 from jposada202020/improving_docs
  > Merge pull request adafruit/Adafruit_CircuitPython_BMP280#30 from jposada202020/removing_pressure_reading_limitations
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_BMP3XX to 1.3.5 from 1.3.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_BMP3XX#16 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_CCS811 to 1.3.4 from 1.3.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_CCS811#45 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_DPS310 to 1.2.4 from 1.2.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_DPS310#12 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_DS1307 to 2.1.7 from 2.1.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_DS1307#22 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_DS18X20 to 1.3.6 from 1.3.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_DS18X20#22 from jposada202020/improving_docs
  > Added note on Raspberry Pi Compatibility
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_DS3231 to 2.4.6 from 2.4.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_DS3231#34 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_HTS221 to 1.1.5 from 1.1.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_HTS221#8 from jposada202020/improving_docs
  > Merge pull request adafruit/Adafruit_CircuitPython_HTS221#7 from micglin/master
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_HTU21D to 0.10.7 from 0.10.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_HTU21D#15 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_LPS2X to 2.0.4 from 2.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_LPS2X#7 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_LPS35HW to 1.2.7 from 1.2.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_LPS35HW#9 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM6DS to 4.1.4 from 4.1.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM6DS#36 from Ninic0c0/master
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_LTR390 to 1.1.1 from 1.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_LTR390#4 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX31855 to 3.2.8 from 3.2.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX31855#24 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX31856 to 0.9.7 from 0.9.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX31856#13 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX31865 to 2.2.9 from 2.2.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX31865#30 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP2515 to 1.0.9 from 1.0.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP2515#9 from jposada202020/correcting_example_name
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP4728 to 1.1.6 from 1.1.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP4728#8 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP9600 to 1.1.6 from 1.1.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP9600#15 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP9808 to 3.3.6 from 3.3.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP9808#28 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_MLX90614 to 1.2.6 from 1.2.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_MLX90614#19 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_MPL3115A2 to 1.2.7 from 1.2.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_MPL3115A2#17 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_MPR121 to 2.1.8 from 2.1.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_MPR121#31 from adafruit/linting
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_MPRLS to 1.2.7 from 1.2.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_MPRLS#15 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_MS8607 to 1.0.7 from 1.0.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_MS8607#8 from jposada202020/adding_board.I2C_reference
  > Merge pull request adafruit/Adafruit_CircuitPython_MS8607#7 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_PCF8523 to 1.5.5 from 1.5.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_PCF8523#22 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_PM25 to 2.1.4 from 2.1.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_PM25#17 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_SCD30 to 2.0.4 from 2.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_SCD30#14 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "
  > Merge pull request adafruit/Adafruit_CircuitPython_SCD30#11 from FoamyGuy/pylint_to_precommit

Updating https://github.com/adafruit/Adafruit_CircuitPython_SGP30 to 2.3.5 from 2.3.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_SGP30#33 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_SGP40 to 1.0.3 from 1.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_SGP40#3 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_SHT31D to 2.3.6 from 2.3.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_SHT31D#20 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_SI7021 to 3.3.4 from 3.3.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_SI7021#22 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_TC74 to 1.0.4 from 1.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_TC74#4 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_TLA202X to 1.0.2 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_TLA202x#2 from jposada202020/correcting_example_name
  > "Increase duplicate code check threshold "
  > Merge pull request adafruit/Adafruit_CircuitPython_TLA202x#1 from FoamyGuy/pylintrc

Updating https://github.com/adafruit/Adafruit_CircuitPython_TM to 1.0.3 from 1.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_TM#4 from jposada202020/correcting_example_name
  > fix spacing
  > Added pylint disable
  > "Increase duplicate code check threshold "
  > Merge pull request adafruit/Adafruit_CircuitPython_TM#3 from FoamyGuy/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_TSL2591 to 1.3.0 from 1.2.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_TSL2591#22 from jposada202020/improving_docs
  > Merge pull request adafruit/Adafruit_CircuitPython_TSL2591#21 from jposada202020/improving_gain_error_code
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_VEML6070 to 3.1.7 from 3.1.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_VEML6070#19 from jposada202020/improving_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_VEML7700 to 1.1.6 from 1.1.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_VEML7700#15 from BrianPugh/master
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_framebuf to 1.4.7 from 1.4.6:
  > Added module docstring
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_hashlib to 1.3.5 from 1.3.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_hashlib#13 from adafruit/linting
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_LED_Animation to 2.5.5 from 2.5.4:
  > Moved to generator
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.6.2 from 1.6.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#37 from makermelissa/main
  > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#35 from FoamyGuy/fix_spi_init

Updating https://github.com/adafruit/Adafruit_CircuitPython_ServoKit to 1.3.4 from 1.3.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_ServoKit#28 from jposada202020/correcting_sphinx_reference
  > "Increase duplicate code check threshold "
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants