Skip to content

Add examples and lint #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 4, 2019
Merged

Add examples and lint #2

merged 5 commits into from
Sep 4, 2019

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Aug 21, 2019

Needs a version of CircuitPython not yet available. Keep an eye out for an ePaper display PR

@tannewt tannewt requested a review from a team August 21, 2019 01:14
@makermelissa
Copy link
Collaborator

Ok @tannewt, it's not working and it's probably something I'm doing wrong, but here's what I did so far. First pulled in the tannewt/epd and compiled for the Feather M4 Express, which was successful. Then I loaded it on the the Feather. I made sure this library was copied over and I used the simepletest example. Here's the error I'm getting:

Traceback (most recent call last):
  File "code.py", line 11, in <module>
  File "/lib/adafruit_il0373.py", line 71, in <module>
AttributeError: 'module' object has no attribute 'EPaperDisplay'

My guess is I need to enable something in some config file to enable ePaper Display support. Thanks.

@makermelissa
Copy link
Collaborator

Nevermind. I compiled while in the wrong branch.

@makermelissa
Copy link
Collaborator

Ok, no errors this time, but it doesn't draw to the EPD. In serial, it says "refreshed" but retains the previous thing that was drawn without drawing anything new.

@makermelissa
Copy link
Collaborator

Oops, didn't realize it needed to work with Tricolor display. Swapped it and it worked great. I'll go through the rest of the examples and if it looks good, I'll approve.

Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you were using the I2C pins for SPI. Let's just change it to board.SPI(). After changing that on my system, it worked great.

@tannewt
Copy link
Member Author

tannewt commented Aug 27, 2019

Are you using a Metro or a Feather? I really dislike using the SPI pins on the Metro because I can never remember which is which. Maybe I should just change this to using a Feather?

@makermelissa
Copy link
Collaborator

I'm using the Metro. I pretty much have the 3 SPI pins burned into my memory from hooking up displays all the time. However, I'm also thinking of consistency for the user experience like for example, they want to try and mash together multiple examples, using SPI for SPI will make that easier. If we want to convert to a feather, I'm also fine with that.

@ladyada
Copy link
Member

ladyada commented Aug 27, 2019

yeah we can use a feather m4 for wiring/testing. please change the SCL/SDA pins to the SPI() default interface

Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@makermelissa makermelissa merged commit 8fc5cae into adafruit:master Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants