make use of core PixelMap #104
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goes along with and relies upon: adafruit/circuitpython#7191
The core PR must get merged before this for it to be functional.
This changes the helper PixelMap class in this library to make use of the core _pixelmap.PixelMap internally. The intention is that the API for adafruit_led_animation.helpers.PixelMap should remain the same as best as possible but make use of the more efficient core class internally.
At this time only basic testing has been performed, so far basic usage and a few of the animations seem to work properly but there is more to check. The helper functions that generate maps for you will need adjusted still as well I think.
A few things to note:
adafruit_pixelmap.PixelMap
? If so this can be closed and I'll cookie cut a new home for this class.