Lovely LIDAR Library #1
Conversation
|
travis passed on first PR, i get a trophy or something!? 😆 |
I'd say that's deserving of a 🌮. Actually, make it two! 🌮 |
| # Uncomment the below if you use native CircuitPython modules such as | ||
| # digitalio, micropython and busio. List the modules you use. Without it, the | ||
| # autodoc module docs will fail to generate with a warning. | ||
| # autodoc_mock_imports = ["digitalio", "busio"] |
There was a problem hiding this comment.
Surprised Shpinx passed without mocking digitalio and micropython. 🤷♂️
Everything else looks good to me, but I'll leave this as a comment and not a review, for now.
There was a problem hiding this comment.
I too am surprised by this. I thought Travis didn't pay attention to requirements.txt until we had another step done, but apparently it does.
There was a problem hiding this comment.
oops i dont know. we remove that for pypi anyways so it would be removed anyhow?
There was a problem hiding this comment.
digitalio and micropython are brought in via Blinka and the updated requirements.txt. Good job all! 🌮
|
huzzah! |
No description provided.