Skip to content

Note that the driver is for the LSM303DLHC #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 25, 2023
Merged

Note that the driver is for the LSM303DLHC #19

merged 2 commits into from
Jan 25, 2023

Conversation

tekktrik
Copy link
Member

Fixes #17

@tekktrik tekktrik requested a review from a team January 24, 2023 04:08
jposada202020
jposada202020 reviewed Jan 24, 2023
View reviewed changes
Copy link
Contributor

@jposada202020 jposada202020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes are good. Verified the readme.rst in your branch and LGTM. A question tho.. is there any reason that I am not aware that we have the a prefix before the sensor reference as in aLSM303DLH instead of LSM303DLH. Thanks :) maybe there is and I did not catch it in PR #16

@tekktrik
Copy link
Member Author

No you're right, I think the a is a typo that I carried over from the issue I made, I think. I can fix that. Good catch!

@jposada202020
Copy link
Contributor

jposada202020 commented Jan 24, 2023 •
edited
Loading

Changes look good. Thank you :)

jposada202020
jposada202020 approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@jposada202020 jposada202020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:) Thanks

@tekktrik tekktrik merged commit b946cfa into adafruit:main Jan 25, 2023
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jan 26, 2023
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@88e01fd)
5a3a52c 
Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM303DLH_Mag to 1.1.17 from 1.1.16:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM303DLH_Mag#19 from tekktrik/dev/note-pn
  > Add upload url to release action
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jposada202020 jposada202020 jposada202020 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Specify this library is for the LSM303DLHC
2 participants
@tekktrik @jposada202020