Skip to content

adding_temperature_property #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2021
Merged

adding_temperature_property #41

merged 1 commit into from
May 11, 2021

Conversation

jposada202020
Copy link
Contributor

solves #25

Add temperature property.
Tested on

Adafruit CircuitPython 6.2.0 on 2021-04-05; Adafruit Feather RP2040 with rp2040

with a LSM6DSOX

using the following code

import time
import board
from adafruit_lsm6ds.lsm6dsox import LSM6DSOX

i2c = board.I2C()
sensor = LSM6DSOX(i2c)

while True:
    print("Temperature: {:.1f} °C".format(sensor.temperature))
    print("")
    time.sleep(1)

@jposada202020 jposada202020 added the enhancement New feature or request label May 11, 2021
@jposada202020 jposada202020 requested a review from a team May 11, 2021 21:56
ladyada
ladyada approved these changes May 11, 2021
View reviewed changes
Copy link
Member

@ladyada ladyada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hopefully ya tested! looks good to me tho

@jposada202020
Copy link
Contributor Author

Yes I did :)

@jposada202020 jposada202020 merged commit fa2cb2c into adafruit:master May 11, 2021
@jposada202020 jposada202020 deleted the adding_temperature_property branch May 11, 2021 22:26
@jposada202020 jposada202020 mentioned this pull request May 11, 2021
Closed
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request May 14, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@41b2432)
e6b56e1 
Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO08X_RVC to 1.0.5 from 1.0.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_BNO08x_RVC#3 from jposada202020/improxing_docs
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_CAP1188 to 1.3.0 from 1.2.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_CAP1188#21 from jposada202020/separating_properties

Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SH1107 to 1.2.0 from 1.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SH1107#5 from lesamouraipourpre/display_offset
  > "Increase duplicate code check threshold "

Updating https://github.com/adafruit/Adafruit_CircuitPython_EMC2101 to 1.1.8 from 1.1.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_EMC2101#17 from jposada202020/correcting_typo

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM6DS to 4.2.0 from 4.1.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM6DS#41 from jposada202020/adding_temperature_property

Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP4728 to 1.2.0 from 1.1.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP4728#10 from codenio/feature/general_call

Updating https://github.com/adafruit/Adafruit_CircuitPython_SI4713 to 1.3.0 from 1.2.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_SI4713#18 from sheimers/master
  > "Increase duplicate code check threshold "
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladyada ladyada ladyada approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jposada202020 @ladyada