Skip to content

Add Missing Type Annotations #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 27, 2022
Merged

Add Missing Type Annotations #14

merged 3 commits into from
Sep 27, 2022

Conversation

tcfranks
Copy link
Contributor

resolves #8
submitted for review / comment

@tekktrik tekktrik self-requested a review September 23, 2022 14:01
tekktrik
tekktrik requested changes Sep 24, 2022
View reviewed changes
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission! Feedback below:

@tcfranks
Copy link
Contributor Author

resubmitted with changes

tekktrik
tekktrik requested changes Sep 25, 2022
View reviewed changes
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small fix:

tekktrik
tekktrik approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tekktrik tekktrik merged commit 3f2ad26 into adafruit:main Sep 27, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Sep 27, 2022
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@eaa233b)
1e4f48e 
Updating https://github.com/adafruit/Adafruit_CircuitPython_BME280 to 2.6.17 from 2.6.16:
  > Merge pull request adafruit/Adafruit_CircuitPython_BME280#62 from rsbohn/dexter0819

Updating https://github.com/adafruit/Adafruit_CircuitPython_HX8357 to 1.3.8 from 1.3.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_HX8357#17 from tcfranks/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_LTR390 to 1.1.11 from 1.1.10:
  > Merge pull request adafruit/Adafruit_CircuitPython_LTR390#14 from tcfranks/main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tekktrik tekktrik tekktrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Type Annotations
2 participants
@tcfranks @tekktrik