Skip to content

Update adafruit_max1704x.py for board ESP323-S3 (no psram) #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

xstook
Copy link
Contributor

@xstook xstook commented Mar 27, 2023

I was getting the exception "Clearing reset alert did not succeed" when trying to initialize the MAX17048 battery monitor on the ESP32-S3 (no psram) board.

I'm running with CircuitPython 8.0.4 and the 8.x Library Bundles built on 3/27/2023.

The line of code giving the error was monitor = adafruit_max1704x.MAX17048(board.I2C()) By changing the loop to run 3 times fixed the issue for me, and I see the comment saying on this board it fails to reset the first time. Like my old mentor used to say, if twice is good three times is better :)

I was getting the exception "Clearing reset alert did not succeed" when trying to initialize the MAX17048 battery monitor on the ESP32-S3 (no psram) board.
I'm running with CircuitPython 8.0.4 and the 8.x Library Bundles built on 3/27/2023.
The line of code giving the error was `monitor = adafruit_max1704x.MAX17048(board.I2C())`
By changing the loop to run 3 times fixed the issue for me, and I see the comment saying on this board it fails to reset the first time. Like my old mentor used to say, if twice is good three times is better :)
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allowing a third try seems reasonable, thanks!

@tekktrik tekktrik merged commit 34e3b51 into adafruit:main Apr 11, 2023
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Apr 12, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX1704x to 1.0.7 from 1.0.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX1704x#11 from xstook/patch-1
  > Add upload url to release action

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants