auto_convert: set/unset bias, + use in read_rtd #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmanuelthome
force-pushed
the
enable_auto_convert
branch
from
2f43d6b to
6bf5b78
Compare
FoamyGuy
approved these changes
Jan 17, 2022
There was a problem hiding this comment.
I tested this successfully using the simpletest with Feather RP2040, it seems to behave as expected.
I don't fully understand what the auto_convert or bias configurations are doing. But did confirm the version from this branch does use the new code as expected when auto_convert is true.
Closed
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jan 18, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX31865 to 2.2.11 from 2.2.10: > Merge pull request adafruit/Adafruit_CircuitPython_MAX31865#33 from emmanuelthome/expose_polarity_and_phase > Merge pull request adafruit/Adafruit_CircuitPython_MAX31865#32 from emmanuelthome/enable_auto_convert > update rtd py version Updating https://github.com/adafruit/Adafruit_CircuitPython_Bitmap_Font to 1.5.4 from 1.5.3: > Merge pull request adafruit/Adafruit_CircuitPython_Bitmap_Font#54 from tekktrik/hotfix/fix-attribute-error > update rtd py version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to enable auto_convert with this small patch:
read_rtd, actually use the auto conversion functionality.This should alleviate the concern raised by #28
Source: https://datasheets.maximintegrated.com/en/ds/MAX31865.pdf , which says:
Actually, I observed that the microcontroller must set VBIAS by itself, the device doesn't seem to do it automagically. If VBIAS is not set by the microcontroller, then there is no continuous update of the resistance readings