Skip to content

Added xtal frequency table for 8MHz #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 8, 2022

Conversation

casainho
Copy link
Contributor

This library did not work with MCP2515 modules with 8MHz xtal, only for 16MHz. I expanded the table to include the 8MHz. The default value still is the 16MHz.

@casainho
Copy link
Contributor Author

I can not understand the existing errors on CI, can someone please tell me what I need to do??

image

@tekktrik
Copy link
Member

You can run pre-commit locally to run black (the formatter tool) and let it reformat the code the way it wants, and then push those changes. That should resolve the CI issues.

@casainho
Copy link
Contributor Author

You can run pre-commit locally to run black (the formatter tool) and let it reformat the code the way it wants, and then push those changes. That should resolve the CI issues.

Thanks @tekktrik. For some reason I could not find a solution, pre-commit is failing on my Linux Ubuntu 22.10. So I am not able to move forward with this.

@tekktrik
Copy link
Member

What is the error you're getting?

@casainho
Copy link
Contributor Author

casainho commented Dec 1, 2022

What is the error you're getting?

Got it solved as it was the same that is as an alert on run pre-commit locally page.

Will push the little changes later.

@casainho
Copy link
Contributor Author

casainho commented Dec 6, 2022

So, all checks passed.

I hope this PR is on your interest and that you will accept it.

Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Feedback below:

@casainho casainho requested a review from tekktrik December 6, 2022 17:44
@casainho
Copy link
Contributor Author

casainho commented Dec 6, 2022

I did the changes your requested - hope everything is fine now.

Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! Just a couple tweaks but otherwise looks great!

@casainho
Copy link
Contributor Author

casainho commented Dec 7, 2022

Hope is ok now.

Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the contribution!

@tekktrik tekktrik merged commit 23ad299 into adafruit:main Dec 8, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Dec 9, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP2515 to 1.0.19 from 1.0.18:
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP2515#15 from casainho/baudrate_for_8mhz_xtal
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_Layout to 1.19.10 from 1.19.9:
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#78 from dhalbert/shorten-filenames
  > Add .venv to .gitignore
  > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#77 from tekktrik/dev/reintroduce-graphviz
  > Update .pylintrc for v2.15.5
  > Fix release CI files
  > Update pylint to 2.15.5
  > Updated pylint version to 2.13.0
  > Switching to composite actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants