Updating for MCP4728A4

[BlitzCityDIY]

Updating library to be able to pass 0x64 I2C address for MCP4728A4 variant (see revision history on product copy: https://www.adafruit.com/product/4470).

[github-actions]

👋 Thanks for this pull request! Unfortunately, it looks like the automated continuous integration (CI) test(s) failed. These can be tricky to fix so we've written a guide on how to fix them locally. It has pages about running pre-commit locally and another about building the docs locally with sphinx. Thanks for contributing to CircuitPython! If you have more questions, feel free to join the Adafruit Discord and post in #circuitpython-dev.

[tekktrik]

Did the CI add all those extra lines in the example file? If possible, it may be more legible to keep it as it was.

For the library, thanks for the type annotation! Perhaps it might be nice to add the different I2C addresses as public global variables at the top:

MCP4728_DEFAULT_ADDRESS = 0x60
MCP4728A4_DEFAULT_ADDRESS = 0x64

Then we can additionally encourage people to use them as/if needed:

i2c = board.I2C()
mcp4728 = MCP4728(i2c, address=MCP4728A4_DEFAULT_ADDRESS)

What do you think, would that be helpful?

[BlitzCityDIY]

Thanks! It totally did add all those lines so I just removed those. This is my first time contributing to a library so I appreciate the feedback! I think global variables would definitely be helpful and I could point them out in the Learn guide. You're saying these variables would be in the example files?

[tekktrik]

If you change _MCP4728_DEFAULT_ADDRESS to MCP4728_DEFAULT_ADDRESS up at the top and add MCP4728A4_DEFAULT_ADDRESS = 0x64 underneath, you could use them in an example file like such:

import board
import adafruit_mcp4728

i2c = board.I2C()  # uses board.SCL and board.SDA

# Use the default address for the MCP4728A4 variant of the board
mcp4728 = adafruit_mcp4728.MCP4728(i2c, address=adafruit_mcp4728.MCP4728A4_DEFAULT_ADDRESS)

...

Just make those changes and push the fix for the extra spaces and it should be good to go!

[BlitzCityDIY]

got it, yeah i definitely like that. just PR'd that update

[tekktrik]

Looks great to me, nice!