Update adafruit_mcp9808.py #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change corrects an error in the temperature function that causes it not to return negative values for the temperature when below 0 degrees Celsius.
|
This change makes the code behave like the Adafruit Python Library https://github.com/adafruit/Adafruit_Python_MCP9808/blob/master/Adafruit_MCP9808/MCP9808.py and the C++ (Arduino) version https://github.com/adafruit/Adafruit_MCP9808_Library/blob/master/Adafruit_MCP9808.cpp |
tannewt
approved these changes
Dec 7, 2017
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Dec 21, 2017
Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP9808 to 3.0.0 from 2.0: > Merge pull request adafruit/Adafruit_CircuitPython_MCP9808#6 from tannewt/lint > Update adafruit_mcp9808.py (adafruit/Adafruit_CircuitPython_MCP9808#5) Updating https://github.com/adafruit/Adafruit_CircuitPython_Thermistor to 3.0.0 from 2.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_Thermistor#1 from tannewt/lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change corrects an error in the temperature function that causes it not to return negative values for the temperature when below 0 degrees Celsius. I noticed the issue, but @Jerryn and @cater figured out how to fix it.