Skip to content

Give all MIDIMessage objects a useful repr() #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 20, 2023
Merged

Give all MIDIMessage objects a useful repr() #53

merged 3 commits into from
May 20, 2023

Conversation

jepler
Copy link
Contributor

@jepler jepler commented May 16, 2023

For example,

>>> from adafruit_midi.note_on import NoteOn
>>> NoteOn(3)
NoteOn(note=3, velocity=127, channel=None)

@github-actions
Copy link

👋 Thanks for this pull request! Unfortunately, it looks like the automated continuous integration (CI) test(s) failed. These can be tricky to fix so we've written a guide on how to fix them locally. It has pages about running pre-commit locally and another about building the docs locally with sphinx. Thanks for contributing to CircuitPython! If you have more questions, feel free to join the Adafruit Discord and post in #circuitpython-dev.

tannewt
tannewt reviewed May 17, 2023
View reviewed changes
@jepler
silence pylint warnings in examples
f89b137 
these modules are imported for the side-effect of importing them
@jepler jepler merged commit c041f8a into main May 20, 2023
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jun 7, 2023
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@b417f43)
6c5c15c 
Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP3xxx to 1.4.15 from 1.4.14:
  > Update .pylintrc, fix jQuery for docs
  > Update pre-commit hooks

Updating https://github.com/adafruit/Adafruit_CircuitPython_MIDI to 1.4.16 from 1.4.15:
  > Update .pylintrc, fix jQuery for docs
  > Merge pull request adafruit/Adafruit_CircuitPython_MIDI#53 from adafruit/useful-repr

Updating https://github.com/adafruit/Adafruit_CircuitPython_Pastebin to 1.0.2 from 1.0.1:
  > Update .pylintrc, fix jQuery for docs
  > Update pre-commit hooks

Updating https://github.com/adafruit/Adafruit_CircuitPython_RGBLED to 1.1.16 from 1.1.15:
  > Update .pylintrc, fix jQuery for docs
  > Update pre-commit hooks

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jepler @tannewt