Ported and tested MLX90614 Object Temperature Sensor Driver #6
Conversation
… prefix on public functions
README.rst
Outdated
| :alt: Discord | ||
|
|
||
| .. image:: https://travis-ci.org/mikeysklar/adafruit_CircuitPython_mlx90614.svg?branch=master | ||
| :target: https://travis-ci.org/mikeysklar/adafruit_CircuitPython_mlx90614 |
There was a problem hiding this comment.
These should be adafruit/Adafruit_CircuitPython_MLX90614 instead of mikeysklar/adafruit_CircuitPython_mlx90614
README.rst
Outdated
| ============ | ||
|
|
||
| Contributions are welcome! Please read our `Code of Conduct | ||
| <https://github.com/mikeysklar/adafruit_CircuitPython_mlx90614/blob/master/CODE_OF_CONDUCT.md>`_ |
adafruit_mlx90614.py
Outdated
| # imports | ||
|
|
||
| __version__ = "0.0.0-auto.0" | ||
| __repo__ = "https://github.com/mikeysklar/Adafruit_CircuitPython_mlx90614.git" |
adafruit_mlx90614.py
Outdated
| @property | ||
| def object_temp_f(self): | ||
| """Object Temperature in fahrenheit.""" | ||
| return (self._read_temp(_MLX90614_TOBJ1) * 9/5) + 32 |
There was a problem hiding this comment.
Remove these. Only provide Celsius to match: https://circuitpython.readthedocs.io/en/latest/docs/design_guide.html#sensor-properties-and-units
I'd also rename object_temperature to temperature so that its available as a standard API. ambient_temp_c should be ambient_temperature.
docs/index.rst
Outdated
| :caption: Related Products | ||
|
|
||
| https://www.adafruit.com/product/1747 | ||
| https://www.adafruit.com/product/1748 |
There was a problem hiding this comment.
Thanks for adding these! Please change them to match the links below with a text name. I'm not sure they work otherwise.
…mbient_temperature
|
Why did this get closed? |
|
Reopening. |
docs/conf.py
Outdated
| # Uncomment the below if you use native CircuitPython modules such as | ||
| # digitalio, micropython and busio. List the modules you use. Without it, the | ||
| # autodoc module docs will fail to generate with a warning. | ||
| # autodoc_mock_imports = ["digitalio", "busio"] |
There was a problem hiding this comment.
This is the line the Travis error is referring to.
|
Thanks for the changes! |
No description provided.