-
Notifications
You must be signed in to change notification settings - Fork 18
Fix #32 #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #32 #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @JulianOrteil!
I have a few changes to request. We'll try to get this tested out as well to ensure some of the new type annotations that haven't been used before won't cause trouble.
@FoamyGuy Other adafruit libraries use the sphinx docstring style (i.e. |
@JulianOrteil Yes, thank you. We use sphinx to build the documentation pages, so we should follow that syntax. |
@FoamyGuy All changes have been implemented. Depending on your answer to my question on 105 and 106, this PR should be ready to merge at your leisure :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for all of your work on this @JulianOrteil!
Updating https://github.com/adafruit/Adafruit_CircuitPython_MPR121 to 2.1.14 from 2.1.13: > Merge pull request adafruit/Adafruit_CircuitPython_MPR121#34 from JulianOrteil/fix-32
Addresses #32.
I also changed docstrings to better conform to PEP257. The style I chose should conform nicely to sphinx as I wasn't able to determine a standard set with this library.