Added support for RGB Matrix FeatherWing #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I forgot to mention, this is useful if somebody wants to have it automatically configure for their setup regardless of network connectivity. |
ladyada
requested changes
Oct 2, 2020
| oe_pin = board.MTX_OE | ||
| else: | ||
| elif hasattr(board, "D7"): | ||
| # Metro/Grand Central Style Board |
There was a problem hiding this comment.
i think maybe better to look in os.uname?
There was a problem hiding this comment.
Cool, I looked for something like that but didn't see it the first time. Thanks.
|
Updated and tested on all 3 boards again. |
ladyada
approved these changes
Oct 2, 2020
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Oct 3, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal to 1.6.0 from 1.5.1: > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#23 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_MotorKit to 1.5.4 from 1.5.3: > Merge pull request adafruit/Adafruit_CircuitPython_MotorKit#33 from caternuson/robot_update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22. This also reduces the number of decision branches and informs Metro Users they need to pass in alt_addr_pins if using a 16x32 matrix.
Tested with: