Skip to content

improve doc and add note to use higher i2C bus speed #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

dhalbert
Copy link
Contributor

Using a higher I2C bus speed to drive the PCA9685 can noticeably speed up motor operation, particularly when many commands are given, such as for stepper motors. Note this in the doc. Also improve the constructor params doc, and fix the formatting of some links.

@dhalbert dhalbert requested a review from a team April 14, 2022 18:19
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small doc fix but otherwise good!

Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's one other doc fix, missed it the first time

Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@tekktrik tekktrik merged commit 2299dba into adafruit:main Apr 14, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Apr 15, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_MotorKit to 1.6.6 from 1.6.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_MotorKit#44 from dhalbert/i2c-speed-doc
  > Update Black to latest.

Updating https://github.com/adafruit/Adafruit_CircuitPython_RSA to 1.2.7 from 1.2.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_RSA#25 from tekktrik/dev/add-dependencies
  > Merge pull request adafruit/Adafruit_CircuitPython_RSA#28 from adafruit/update-badge-url
  > Update Black to latest.
  > Fixed readthedocs build
  > Consolidate Documentation sections of README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants