Skip to content

simpletest from ladyada #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 7, 2023
Merged

simpletest from ladyada #16

merged 2 commits into from
Mar 7, 2023

Conversation

jepler
Copy link
Contributor

@jepler jepler commented Feb 13, 2023

will be back for the pylintening

@github-actions
Copy link

👋 Thanks for this pull request! Unfortunately, it looks like the automated continuous integration (CI) test(s) failed. These can be tricky to fix so we've written a guide on how to fix them locally. It has pages about running pre-commit locally and another about building the docs locally with sphinx. Thanks for contributing to CircuitPython! If you have more questions, feel free to join the Adafruit Discord and post in #circuitpython-dev.

@FoamyGuy
Copy link
Contributor

FoamyGuy commented Mar 6, 2023

I took a shot at resolving the pylint issues.

The biggest factor was this file seemed to contain two examples one after the other. I split them into separate files ov5640_pico_simpletest.py and ov5640_pico_st7789.py and the majority of the pylint issues went away. The few remaining were some unused imports.

I also renamed the files to use ov5640_ as the first part of the name. I forget exactly what it is, but I think there is something that assumes example file names will have the library name at their beginning.

@FoamyGuy FoamyGuy requested a review from a team March 6, 2023 16:47
dhalbert
dhalbert approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@dhalbert dhalbert merged commit 3d3c316 into main Mar 7, 2023
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Mar 15, 2023
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@2415fa6)
3f1c788 
Updating https://github.com/adafruit/Adafruit_CircuitPython_OV5640 to 1.1.10 from 1.1.9:
  > Merge pull request adafruit/Adafruit_CircuitPython_OV5640#16 from adafruit/pico-simpletest
  > Add upload url to release action
  > Add .venv to .gitignore
  > Update .pylintrc for v2.15.5
  > Fix release CI files
  > Update pylint to 2.15.5
  > Updated pylint version to 2.13.0
  > Switching to composite actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_TM to 1.1.8 from 1.1.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_TM#14 from jposada202020/correcting_measurement_mode
  > Add upload url to release action
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jepler @FoamyGuy @dhalbert