Skip to content

Fix effects modes #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 12, 2021
Merged

Fix effects modes #7

merged 5 commits into from
Oct 12, 2021

Conversation

jepler
Copy link
Contributor

@jepler jepler commented Oct 12, 2021 •
edited
Loading

This fixes:

  • contrast "+2" setting was wrong
  • brightness caused an exception when set
  • The 'normal' special effect was different than the initial settings

It also adds a testing mode to the "directio" example which cycles through the modes. Enable it by changing a line near the top of the example:

# Set to True to enable the various effects & exposure modes to be tested
test_effects = False

@jepler jepler requested a review from ladyada October 12, 2021 19:23
@ladyada
Copy link
Member

ladyada commented Oct 12, 2021

didnt test but i belive it!

@ladyada ladyada merged commit 64b85d7 into main Oct 12, 2021
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Oct 15, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@b81efd7)
e031f83 
Updating https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3741 to 1.1.4 from 1.1.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3741#8 from jsymons/typing

Updating https://github.com/adafruit/Adafruit_CircuitPython_OV5640 to 1.0.1 from 1.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_OV5640#7 from adafruit/fix-effects-modes
  > Merge pull request adafruit/Adafruit_CircuitPython_OV5640#5 from adafruit/boost-pixel-clock

Updating https://github.com/adafruit/Adafruit_CircuitPython_Seesaw to 1.10.1 from 1.10.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#86 from kattni/simpletest
@jepler jepler deleted the fix-effects-modes branch October 17, 2021 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladyada ladyada ladyada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jepler @ladyada