Skip to content

Linted #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2021
Merged

Linted #7

merged 2 commits into from
May 21, 2021

Conversation

evaherrada
Copy link
Collaborator

No description provided.

@github-actions
Copy link

👋 Thanks for this pull request! Unfortunately, it looks like the automated continuous integration (CI) test(s) failed. These can be tricky to fix so we've written a guide on how to fix them locally. It has pages about running pre-commit locally and another about building the docs locally with sphinx. Thanks for contributing to CircuitPython! If you have more questions, feel free to join the Adafruit Discord and post in #circuitpython-dev.

@evaherrada
Copy link
Collaborator Author

@tannewt do I need to mock something for this? I don't think I've ever come across something that has failed in this specific way

@tannewt
Copy link
Member

tannewt commented May 20, 2021

Looks like monotonic_ns was added in Python 3.7: https://docs.python.org/3/library/time.html#time.monotonic_ns We should probably switch everything to 3.7 or newer from 3.6.

@evaherrada
Copy link
Collaborator Author

@tannewt Ok. I'll make a patch for that

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@tannewt tannewt merged commit 568680f into main May 21, 2021
@evaherrada evaherrada deleted the linting branch May 21, 2021 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants