Skip to content

pylint party #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 26, 2018
Merged

pylint party #2

merged 3 commits into from
Aug 26, 2018

Conversation

ladyada
Copy link
Member

@ladyada ladyada commented Aug 25, 2018 •
edited
Loading

@ladyada ladyada requested a review from a team August 25, 2018 20:41
sommersoft
sommersoft approved these changes Aug 26, 2018
View reviewed changes
Copy link
Collaborator

@sommersoft sommersoft left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I won't merge, in case smarter heads spot something structure-wise that I don't see.

Notes:

  • Slicing is used heavily. I remember a while ago that slicing wasn't universally available, but after checking the various mpconfigports for CircuitPython it looks like nRF is the only one left out. So that should be fine, since it is still in work. EDIT: slicing is good to go across the board.

  • adafruit_pn532.py Line 291: empty lists as default arguments are generally avoided, hence pylint complaining. However, since the argument isn't mutated it should be fine. I ran some tests in the REPL to mimic, and didn't see any undesired behavior.

Thanks ladyada!

@ladyada
Copy link
Member Author

ladyada commented Aug 26, 2018

awesome, thanks! yeah this chip is hard to use but i think i got it into a reasonable spot

@ladyada ladyada merged commit b3c2831 into adafruit:master Aug 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sommersoft sommersoft sommersoft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ladyada @sommersoft