This repository was archived by the owner on Apr 20, 2022. It is now read-only.
First PR of the pure python Pypixelbuf library #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
suggested changes
Jun 25, 2019
.travis.yml
Outdated
| # or remove the env block entirely and remove the condition in the | ||
| # deploy block. | ||
| env: | ||
| - DEPLOY_PYPI="false" |
There was a problem hiding this comment.
I think you will want to do this.
tannewt
reviewed
Jun 25, 2019
.travis.yml
Outdated
| - pip install --force-reinstall pylint==1.9.2 | ||
|
|
||
| script: | ||
| - pylint adafruit_dotstar.py |
There was a problem hiding this comment.
The build is failing because this is incorrect.
tannewt
approved these changes
Jul 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preliminary PR for pypixelbuf @kattni
There are some changes needed to shrink the code still.