Skip to content
This repository was archived by the owner on Apr 20, 2022. It is now read-only.

Implement adafruit_pypixelbuf necessary for neopixel and dotstar without _pixelbuf #3

Merged
merged 15 commits into from
Jan 7, 2020

Conversation

rhooper
Copy link
Contributor

@rhooper rhooper commented Jan 2, 2020

No description provided.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the doc todos need to be done and removed. Everything else looks good. We will want this on pypi so the Blinka boards use it too.

Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the following in place of #-- PASTE ENCRYPTED PASSWORD HERE --# on line 34 of .travis.yml:

cBnTT/A6ePSz/eNidwxs9S6GamtLqc6z+a1GyV+Z0sNBtIyHmXIClvJKeGkJEQDtO6kHftNy+UhW6bQPrmRK8d3vcysHriLuFBWhViteBHNHSpacTXmbqbE3leavV0mHu3lX4moP2a3kYgk/kMNF6p9YNNyJPRshFpm930Wiq9Nn1zPh3ethjTY/EuFJt5KxxSzmCUYRqLSsGOV777UaPCIC4pft8smPIfTNcAmvFO1mlPFEikCbWg9fGq68PfJ5mEyvlgJrDS9ptEAIBNwu44+wMiVKVxit9PiifjY1FerAVP1s+Ka2IdkLB7JQZmBQMXJ51uLabRPfshwOhi28Lkc+0zJb3UzmTh6pXDUmfutlRAdVdY1HxfDpqzMvjt2FOGBMRm7fd0YUcIUMGX8SDbXoOL6fNeWAW3+ajiO2BTa+4cHrrn7q0UmnhRna3dos8jA9oGir2bkR97IYVjaJD9h3/BejMSiHXLRXSX7qTjh47JFWI9aW8eRGqhfXPnjsp1RZIizINJS3QIjysTZZCzSbMH+6fADqX820kU85w5gAol4zwveTAjoN3vGphyHgjFRcXe5lpqgUJXMveE3ywgwNvWheAQiniw+Tkl2mQ/zo9UwS6jwMJFyug+9FPrtxsn0pLZRPGEtnp/LbZfQuS1DZ6ZhL7tHjAHjm1rE0N+k=

Then delete both TODO: comment blocks in the same file and make the changes listed below.

Please ping me if any of this is unclear. Thanks!

@kattni
Copy link
Contributor

kattni commented Jan 2, 2020

I was unable to review lines not included in changes, so the review includes half of the necessary changes in a review comment, and half of them on the specific lines requiring changes. Please let me know if any of it is unclear. Thank you!

@siddacious siddacious self-requested a review January 2, 2020 22:53
Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See below to resolve the current Travis issue.

Copy link
Contributor

@siddacious siddacious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhooper @kattni, sorry I just noticed this. let's get this using the actions workflow instead of setting up travis only to have Dylan undo it.

Copy link
Contributor

@siddacious siddacious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just have to add the build badge and it should be good to go on my end

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release.yml and build.yml are in the incorrect location. They should be in .github/workflows/ iirc. They should run if it is set up correctly.

@rhooper
Copy link
Contributor Author

rhooper commented Jan 3, 2020

Sorry about that, I haven't used github actions before, so incorrectly assumed they were just like all other CI/CD systems I've used - that look in the root directory by default for CI/CD config.

I see cookiecutter got updated a day after I used it last :)

@siddacious
Copy link
Contributor

Great review job @siddacious 🙄

@rhooper
Copy link
Contributor Author

rhooper commented Jan 4, 2020

Once this gets merged to master and put in PyPi I can finish getting https://github.com/rhooper/Adafruit_CircuitPython_DotStar/tree/pixelbuf
and
https://github.com/rhooper/Adafruit_CircuitPython_NeoPixel/tree/pixelbuf
to pass the build.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@siddacious siddacious merged commit e71a141 into adafruit:master Jan 7, 2020
@kattni
Copy link
Contributor

kattni commented Jan 7, 2020

@rhooper This is now on PyPI! We can move forward with NeoPixel and DotStar at any time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants